Fix a flaky test by cleaning a polluted state.#4
Open
sturmianseq wants to merge 1 commit intokivio:masterfrom
Open
Fix a flaky test by cleaning a polluted state.#4sturmianseq wants to merge 1 commit intokivio:masterfrom
sturmianseq wants to merge 1 commit intokivio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to fix a flaky test
tests/test_propagation_logger.py::test_forcing_level_by_dict, which can fail after runningtests/test_propagation_logger.py::test_forcing_level_by_level_name, but passes when run in isolation.Reproduce the test failure
Run the following command:
Expected result
tests/test_propagation_logger.py::test_forcing_level_by_dictshould pass after runningtests/test_propagation_logger.py::test_forcing_level_by_level_name.Actual result
Why it fails
propagation_loggeris polluted after runningtests/test_propagation_logger.py::test_forcing_level_by_level_name.Fix
Reset
propagation_loggerat the beginning oftests/test_propagation_logger.py::test_forcing_level_by_dict